Add loopback.runInContext
#1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Refactor the core implementation of current context from server/middleware/context.js into server/current-context.js. Expose new public API: - loopback.runInContext - loopback.createContext
bajtos
force-pushed
the
feature/run-in-context
branch
from
0e280fc to
2aa09ba
Compare
|
May be out of scope completely, but do you know of way to run out of scope? Use case: running some piece of code that is async (Job on another node) Thanks a lot
|
|
@seriousben I am afraid I don't understand you. You want to step outside of the current context, so that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the core implementation of current context from
server/middleware/context.jsintoserver/current-context.js.Expose new public API:
loopback.runInContextloopback.createContextConnect to #982
Browser support is out of scope of this pull request, see othiym23/node-continuation-local-storage#36
/to @raymondfeng @ritch please review