Temporary fix for flutter-web compatibility. #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have merged #78 as it too solved the issue, just with less code. Thanks for the contribution though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling for web currently fails because of the use of dart:io (used as Platform.is* in platform.dart), which is not supported for web. Discussion
So far there doesn't seem to be anything like Platform.isWeb. Also what style should be used for web is questionable, perhaps making it Material by default for now is the best idea and users should be still able to switch between Material/Cuportino if they wish (again not sure if web supports Cuportino at this point).
This PR works around the Platform.* statements by utilizing the temporary(?) constant kIsWeb from Flutter foundation.