Feature/angular 20 update and migration #454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x-store unit tests
… because of functional reasons (not related to the upgrade)
…e scripts in package.json
DenisValcke
added
publish
ekincia
reviewed
Sep 25, 2025
| @@ -1,4 +1,4 @@ | |||
| MIT License | |||
| lcMIT License | |||
ekincia
reviewed
Sep 25, 2025
| styleUrls: ['./error.component.scss'], | ||
| standalone: true, | ||
| imports: [CommonModule], | ||
| imports: [], |
There was a problem hiding this comment.
I would delete this, since it's empty.
ekincia
reviewed
Sep 25, 2025
|
|
||
| @Component({ | ||
| imports: [CommonModule], | ||
| imports: [], |
ekincia
reviewed
Sep 25, 2025
| selector: '[ngxHasFeature]', | ||
| }) | ||
| export class NgxHasFeatureDirective<FeatureType extends string> implements OnDestroy { | ||
| templateRef = inject<TemplateRef<any>>(TemplateRef); |
| private readonly cdRef: ChangeDetectorRef | ||
| ) { | ||
| constructor() { | ||
| const templateRef = inject<TemplateRef<any>>(TemplateRef); |
There was a problem hiding this comment.
Shouldn't this be outside of the constructor?
| private viewContainer: ViewContainerRef | ||
| ) { | ||
| constructor() { | ||
| const templateRef = inject<TemplateRef<any>>(TemplateRef); |
ekincia
reviewed
Sep 25, 2025
|
|
||
| service = runInInjectionContext(child, () => inject(NgxWindowService)); | ||
|
|
||
| // service = runInInjectionContext(parent, () => inject(NgxWindowService)); |
There was a problem hiding this comment.
If it's not needed, delete it.
| providedIn: 'root', | ||
| }) | ||
| export class NgxWindowService { | ||
| document = inject<Document>(DOCUMENT); |
| private readonly dropList = inject(CdkDropList); | ||
| private readonly dropContainer = inject(NgxAccessibleDragAndDropContainerDirective); | ||
| private readonly dropHost = inject(NgxAccessibleDragAndDropHostDirective); | ||
| readonly elementRef: ElementRef<HTMLElement>; |
| standalone: true, | ||
| }) | ||
| export class NgxTourItemDirective implements AfterViewInit, OnDestroy { | ||
| readonly elementRef = inject<ElementRef<HTMLElement>>(ElementRef); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all changes for the Angular 20 migration (including version bumps for all packages).
Requirements