Adding filePath to parser results #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser is able to analyze and return multiple exported components per module/file.
Once we parse multiple files on a single run (
reactDocgenTS.parse(arrayOfFiles)
) it is non trivial to parse what module a component corresponds to.In our case, we want to use the filePath to extract some data on the file context (git, projects, etc) to enrich the data returned by the parser.
Worked around this initially by setting a custom
componentNameResolver
that returns the name and the filename instead of a string (And then updating some types), but it's not ideal, or a future-safe idea for the matter)