Fix shouldRemoveUndefinedFromOptional in TypeScript strict mode #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
LGTM ... @pvasek I would suggest to add prettier and husky in one of the next iterations to prevent these kinds of things.
|
@michelengelen I am definitely open to anything which can help to avoid this kind of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #341
What I did
The
shouldRemoveUndefinedFromOptionalwas broken for TypeScriptstrict: truemode.undefinedto enums/unionsWill fix storybookjs/storybook#14523
How to test
See attached unit tests cc @michelengelen