✨(frontend) add pdf block to the editor #1293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed content disposition as inline so that pdf is not downloaded automatically. Signed-off-by: dakshesh14 <[email protected]>
Added pdf block in the editor. Signed-off-by: dakshesh14 <[email protected]>
Moved drag handler logic to a hook to make component dumb. Signed-off-by: dakshesh14 <[email protected]>
Made docx and pdf export mapper for the newly added pdf block Signed-off-by: dakshesh14 <[email protected]>
|
Hey team, This is a duplicate of PR-795, since I couldn’t reopen the original after losing the fork. I’d appreciate the maintainers’ input on a few points where the implementation could be improved:
Looking forward to your feedback and happy to adjust the implementation accordingly. |
Added pr number in changelog Signed-off-by: dakshesh14 <[email protected]>
|
Hey @dakshesh14 ! |
|
Hey @virgile-dev, happy to be back! No problem at all - I’ll wait for @AntoLC to return and review the PR. Thanks for keeping me posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added an option for users to upload and preview PDF files in the editor. This PR addresses #348. It is a duplicate of PR-795 because I couldn't reopen the PR as I lost my fork.
pdf-embed.webm
Proposal
Added the option for users to upload and preview PDF files within the editor.
Description: