mail: make DIR_MAILS variable changeable #1300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That allows downstream packages to e.g. split the builds of frontend/backend/mail, as it's the case in nixpkgs: NixOS/nixpkgs@5597a4f Signed-off-by: Maximilian Bosch <[email protected]>
13 tasks
lunika
reviewed
Aug 25, 2025
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
| set -eo pipefail | |||
| # Run html-to-text to convert all html files to text files | |||
| DIR_MAILS="../backend/core/templates/mail/" | |||
| DIR_MAILS="${DIR_MAILS:-../backend/core/templates/mail}/" | |||
There was a problem hiding this comment.
Good idea but maybe use a prefix ? DOCS_DIR_MAILS ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
That allows downstream packages to e.g. split the builds of frontend/backend/mail, as it's the case in nixpkgs: NixOS/nixpkgs@5597a4f
Proposal
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)