Skip to content

🩹(frontend) minor issues #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025
Merged

🩹(frontend) minor issues #840

merged 6 commits into from
Apr 7, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Apr 4, 2025

Purpose

  • 🐛(frontend) fix selection click past end of content
  • ♻️(frontend) misc improvements
  • 🐛(frontend) do not display firefox modal if not necessary
  • ♻️(frontend) icon component refactoring
  • ✨(frontend) update favicon files and links
  • 🥚(frontend) remove easter egg

@AntoLC AntoLC self-assigned this Apr 4, 2025
@AntoLC AntoLC force-pushed the fix/minor-issues branch from ba5a1ce to 6fd5d6c Compare April 4, 2025 07:11
@AntoLC AntoLC added frontend bug Something isn't working labels Apr 4, 2025
@AntoLC AntoLC requested a review from PanchoutNathan April 4, 2025 07:13
@AntoLC AntoLC force-pushed the fix/minor-issues branch 2 times, most recently from 897109e to eff1683 Compare April 7, 2025 09:55
@AntoLC AntoLC enabled auto-merge (rebase) April 7, 2025 10:03
@AntoLC AntoLC force-pushed the fix/minor-issues branch from eff1683 to 1ef165e Compare April 7, 2025 10:30
AntoLC and others added 6 commits April 7, 2025 13:03
On Chrome, when we click at the end of a line,
the cursor is placed at the beginning of the line.
We fix this behavior, now the cursor is placed
at the end of the line.
- add opacity props on Box
- rename to cunningham-style.css
- update illustration-docs-empty.png
- smaller tooltip
It is necessary to display the firefox modal only
if the user has something to save.
- Add variant to IconComponent and remove $isMaterialIcon prop
- Replace all Text component used as icon with the Icon component.
- Added new favicon files: favicon-dark.png and favicon.png.
- Updated the _app.tsx file to link to the new favicon files, supporting
both light and dark color schemes.
Remove the easter egg from the console.
@AntoLC AntoLC force-pushed the fix/minor-issues branch from 1ef165e to d98e736 Compare April 7, 2025 11:04
@AntoLC AntoLC merged commit de8e812 into main Apr 7, 2025
19 of 20 checks passed
@AntoLC AntoLC deleted the fix/minor-issues branch April 7, 2025 11:18
@AntoLC AntoLC mentioned this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants