-
Notifications
You must be signed in to change notification settings - Fork 283
🚩(frontend) version MIT only #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c397033
to
1e66bcd
Compare
Hey! Keep in mind that this has to work for all XL packages that have AGPL licences that we will want to include. |
We have some packages that are not MIT compatible, so if the env var MIT_ONLY is set to true, we don't build the application with features that are not MIT compatible. For the moment, it concerns only the export packages.
1e66bcd
to
9166e7b
Compare
The name The "only" seems to indicate you only want MIT-licensed lib, which I guess is not what you really want. I suggest |
I changed it to By default docs/src/frontend/apps/impress/.env Line 3 in 3693f0c
It will have to be set to false explicitly before building the image in order to have the export feature. docs/.github/workflows/docker-hub.yml Line 84 in 3693f0c
Could you give a hand you think about how to document this env variable in our documentation ? |
3693f0c
to
2779c61
Compare
While attempting to find my way through documenting |
Purpose
We have some packages that are not MIT compatible, so if the env var
MIT_ONLY
is set to true, we don't build the application with features that are not MIT compatible.For the moment, it concerns only the export packages.
Proposal
Set the environement variable:
MIT_ONLY=false
-> will include the export featureDemo
Thanks to the treeshacking, the packages of the features not included will not be included as well.
toReactPDFDocument
is a method from@blocknote/xl-pdf-exporter
, we will search the method in the js files of the app:With

MIT_ONLY=false
With

MIT_ONLY=true