fix: preserve user metadata when email_confirm=true in Confirm function #2089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When creating a user with
email_confirm: true
, theConfirm
function ininternal/models/user.go
overwrites the user's existing metadata instead of merging theemail_verified: true
flag with it.#2088
Root cause
The current implementation calls
UpdateUserMetaData
with only{"email_verified": true}
, which replaces the entire metadata object instead of merging with existing data.Example of data loss
What is the new behavior?
The
Confirm
function now properly preserves existing user metadata by:email_verified: true
flag with existing metadataUpdateUserMetaData
function to properly update without data lossExample of correct behaviour: