Skip to content

fix: FunctionsClient constructor default options #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

egor-romanov
Copy link
Collaborator

What kind of change does this PR introduce?

fix FunctionsClient constructor

What is the current behavior?

FunctionsClient constructor requires to pass {} as options if you don't want to pass headers or fetch

What is the new behavior?

Add options default value {} in FunctionsClient constructor

@soedirgo
Copy link
Member

soedirgo commented Apr 4, 2022

Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave the headers default initialisation to empty object in the constructor. Wdyt?

I like the addition of making full constructor options default to empty object and therefore optional 👍

@egor-romanov egor-romanov merged commit 0516093 into main Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

🎉 This PR is included in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thorwebdev thorwebdev deleted the func-client-default-options branch April 5, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants