Skip to content

fix: exclude bucket type in response for storage-py < 0.12.1 #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

itslenny
Copy link
Contributor

@itslenny itslenny commented Aug 7, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

bucket list endpoint response includes a bucket type property for all requests

What is the new behavior?

bucket type property is excluded for storage-py versions before 0.12.1

Additional context

The storage-py client library throws a fatal error if it receives unexpected properties in the bucket list response. The type property was added to the expected values in v0.12.1

Fix PR: supabase/storage-py#380
Fix Release: https://github.com/supabase/storage-py/releases/tag/v0.12.1

@coveralls
Copy link

coveralls commented Aug 7, 2025

Pull Request Test Coverage Report for Build 16810181984

Details

  • 31 of 31 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 76.84%

Files with Coverage Reduction New Missed Lines %
src/internal/database/tenant.ts 2 83.25%
Totals Coverage Status
Change from base Build 16779075761: 0.02%
Covered Lines: 21003
Relevant Lines: 27095

💛 - Coveralls

@itslenny itslenny force-pushed the lenny/exclude-bucket-type-for-old-storage-py-versions branch 2 times, most recently from cc9a4e4 to d7c7eaf Compare August 7, 2025 16:24
@itslenny itslenny force-pushed the lenny/exclude-bucket-type-for-old-storage-py-versions branch from d7c7eaf to dd4d611 Compare August 7, 2025 16:27
@itslenny itslenny merged commit 861dc29 into master Aug 7, 2025
2 checks passed
@itslenny itslenny deleted the lenny/exclude-bucket-type-for-old-storage-py-versions branch August 7, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants