refactor: use URL type for manipulating urls #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Refactors URL handling in SupabaseClient to use native URL objects and improves header merging in helper defaults.
- Client endpoint properties (
realtimeUrl,authUrl, etc.) are nowURLinstances, and consumers call.toString()where needed. - Deep merge of default and custom
headersadded inapplySettingDefaults. - Old
client.test.tsremoved and replaced with a new, more comprehensiveSupabaseClient.test.ts.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/helpers.test.ts | Update header assertion to use toStrictEqual |
| test/client.test.ts | Remove deprecated client tests (superseded by SupabaseClient suite) |
| test/SupabaseClient.test.ts | Add comprehensive tests for URL construction, clients, and behaviors |
| src/lib/helpers.ts | Explicitly merge default and custom headers in applySettingDefaults |
| src/SupabaseClient.ts | Change endpoint props to URL, use URL API for building endpoints, update consumers |
Comments suppressed due to low confidence (1)
test/helpers.test.ts:39
- Add a unit test case to verify that when
global.headersare provided,applySettingDefaultscorrectly merges them with the default headers.
expect(settings.global.headers).toStrictEqual(DEFAULT_HEADERS)
hf
reviewed
May 19, 2025
| this.storageUrl = `${_supabaseUrl}/storage/v1` | ||
| this.functionsUrl = `${_supabaseUrl}/functions/v1` | ||
| this.realtimeUrl = new URL('/realtime/v1', baseUrl) | ||
| this.realtimeUrl.protocol = this.realtimeUrl.protocol.replace('http', 'ws') |
There was a problem hiding this comment.
Was gonna say just do = 'ws:' but I see what you did. ✅
hf
reviewed
May 19, 2025
src/SupabaseClient.ts
Outdated
| @@ -137,7 +139,7 @@ export default class SupabaseClient< | |||
| * Supabase Functions allows you to deploy and invoke edge functions. | |||
| */ | |||
| get functions(): FunctionsClient { | |||
| return new FunctionsClient(this.functionsUrl, { | |||
| return new FunctionsClient(this.functionsUrl.toString(), { | |||
There was a problem hiding this comment.
Isn't this the right way?
Suggested change
| return new FunctionsClient(this.functionsUrl.toString(), { | |
| return new FunctionsClient(this.functionsUrl.href, { |
hf
approved these changes
May 19, 2025
2 tasks
grdsdev
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.