Skip to content

feat: edge functions support for custom domains and vanity domains #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

feat: edge functions support for custom domains and vanity domains #778

merged 1 commit into from
May 30, 2023

Conversation

delgado3d
Copy link
Contributor

What kind of change does this PR introduce?

feature

What is the new behavior?

Invoke functions with /functions/v1 path prefix allowing us to support custom domains and vanity domains for edge functions

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5094229097

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.02%) to 66.492%
Totals Coverage Status
Change from base Build 5089128794: -1.02%
Covered Lines: 83
Relevant Lines: 107
💛 - Coveralls

@delgado3d delgado3d requested review from laktek, inian and thorwebdev May 26, 2023 19:15
thorwebdev
thorwebdev approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@delgado3d delgado3d merged commit 2fdfe17 into master May 30, 2023
@delgado3d delgado3d deleted the dd/functions-custom-domains branch May 30, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorwebdev thorwebdev thorwebdev approved these changes

@laktek laktek Awaiting requested review from laktek

@inian inian Awaiting requested review from inian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delgado3d @thorwebdev