Skip to content

chore: fixed some types #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023
Merged

chore: fixed some types #471

merged 1 commit into from
Jun 19, 2023

Conversation

Ananya2001-an
Copy link
Contributor

What kind of change does this PR introduce?

Fixed some types and also refactored the client options test by creating a class to make it more readable.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.37 ⚠️

Comparison is base (8e341c7) 79.75% compared to head (c0da631) 79.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #471      +/-   ##
===========================================
- Coverage    79.75%   79.39%   -0.37%     
===========================================
  Files            9        9              
  Lines          163      165       +2     
===========================================
+ Hits           130      131       +1     
- Misses          33       34       +1     
Impacted Files Coverage Δ
supabase/lib/auth_client.py 81.81% <66.66%> (-7.08%) ⬇️
supabase/client.py 93.33% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I like the changes made to the auth_client type hints but I have some questions about the other changes

@anand2312 anand2312 requested a review from J0 June 19, 2023 16:05
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@J0 J0 merged commit e5fc57a into supabase:develop Jun 19, 2023
@Ananya2001-an Ananya2001-an deleted the chore-typing branch June 20, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants