-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
export VERSION
from @sveltejs/kit
#9969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
427083b
export `VERSION` from `@sveltejs/kit`
ivanhofer 0a5ea8f
add changeset
ivanhofer a4155c8
auto update version in CI
ivanhofer 2e1057b
format files
ivanhofer cc10009
Update packages/kit/src/version.js
Rich-Harris 6650624
Update .changeset/unlucky-eagles-destroy.md
Rich-Harris c900783
simplify script
d6df640
oops
f0e3dc3
oops
57f13de
adapt to svelte setup
cc0f567
import version after updating it
91fcda9
fix export
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': patch | ||
--- | ||
|
||
feat: export `VERSION` from `@sveltejs/kit` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import fs from 'node:fs'; | ||
|
||
const pkg = JSON.parse(fs.readFileSync('package.json', 'utf-8')); | ||
|
||
fs.writeFileSync( | ||
'./src/version.js', | ||
`// generated during release, do not modify\n\n/** @type {string} */\nexport const VERSION = '${pkg.version}';\n` | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// generated during release, do not modify | ||
|
||
/** @type {string} */ | ||
export const VERSION = '1.20.4'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { fileURLToPath } from 'node:url'; | ||
import { readFileSync } from 'node:fs'; | ||
import { assert, describe, it } from 'vitest'; | ||
|
||
// runs the version generation as a side-effect of importing | ||
import '../scripts/generate-version.js'; | ||
|
||
describe('@sveltejs/kit VERSION', async () => { | ||
it('should be the exact version from package.json'); | ||
const { VERSION } = await import('./version.js'); | ||
const pkg = JSON.parse( | ||
readFileSync(fileURLToPath(new URL('../package.json', import.meta.url)), 'utf-8') | ||
); | ||
assert.equal( | ||
VERSION, | ||
pkg.version, | ||
'VERSION export in src/version.js does not equal version in package.json' | ||
); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure where to put this..
There is no build step involved in this repo.
I guess this is needed when running the tests and for publishing
pnpm changeset:version
should be called. Are there also other places where it is needed to update the version info?