Skip to content

feat: set compilerOptions.css to 'external' when emitCss was true #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2023
Merged

feat: set compilerOptions.css to 'external' when emitCss was true #211

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f05a504
feat: compilerOptions.css as a boolean is deprecated. Use 'external' …
gucheen Jun 26, 2023
4a71313
feat: css option value by svelte compiler version
gucheen Jun 26, 2023
baeb711
fix: major version compare
gucheen Jun 26, 2023
07e96c3
feat: use new css option after svelte v4
gucheen Jun 26, 2023
1e050e1
fix: css boolean value
gucheen Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ module.exports = function (options = {}) {
const { onwarn, emitCss = true } = rest;

if (emitCss) {
const [majorVer, minorVer] = VERSION.split('.');
const cssOptionValue = majorVer > 3 || (majorVer >= 3 && minorVer >= 53) ? 'external' : true;
if (compilerOptions.css) {
console.warn(
`${PREFIX} Forcing \`"compilerOptions.css": false\` because "emitCss" was truthy.`
`${PREFIX} Forcing \`"compilerOptions.css": ${typeof cssOptionValue === 'string' ? `"${cssOptionValue}"` : cssOptionValue}\` because "emitCss" was truthy.`
);
}
compilerOptions.css = false;
compilerOptions.css = cssOptionValue;
}

return {
Expand Down