Svelte 5: Snippets aren't deconflicted

[Rich-Harris]

Describe the bug

It should be possible to have two snippets with the same name in different scopes. Right now, the second clobbers the first.

Reproduction

link

Logs

No response

System Info

next

Severity

annoyance

[trueadm]

I originally thought to make the snippets const and then wrap their element scope in a block statement. This fixes this particular bug, but then they're no longer accessible in the <script> and the tests that test for that fail. I guess the only option is to rename the deconflicted variables instead.

[Rich-Harris]

Snippets declared inside an element (or anything else) shouldn't be accessible in the <script>

[trueadm]

Ah there were issues in my approach. Notably, we can't just wrap the init in a block statement, we also have to account for the after_update and update logic too. However, we can't really wrap them in the same block statement as they're designed to come much later on. Eh.

[dummdidumm]

top level is function or var, nested ones are const?

[trueadm]

Got it working locally, PR incoming.