Skip to content

sanitize filenames before SSRing #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2017
Merged

sanitize filenames before SSRing #1006

merged 2 commits into from
Dec 11, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #1005

@codecov-io
Copy link

codecov-io commented Dec 11, 2017

Codecov Report

Merging #1006 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         115      115           
  Lines        4297     4297           
  Branches     1369     1369           
=======================================
  Hits         3956     3956           
  Misses        148      148           
  Partials      193      193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efd1a9...6843994. Read the comment docs.

@Conduitry
Copy link
Member

Ha I was just about to ask you to use a different character so as to not break cloning on Windows and I saw you bumped into that via CI

@Rich-Harris
Copy link
Member Author

yep! not the first or last time Appveyor has saved us trouble. Background: I'm looking into the possibility of next.js-style apps (https://github.com/Rich-Harris/sapper) for Svelte, and I wanted to be able to encode parameters in file names. So far my preference is for routes/post/%id%.html -> /post/:id.

@Rich-Harris Rich-Harris merged commit 774caf4 into master Dec 11, 2017
@Rich-Harris Rich-Harris deleted the gh-1005 branch December 11, 2017 15:11
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
* import correct version, as determined by package.json

* more

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssr/register should sanitize filenames
3 participants