Skip to content

allow options outside <select> elements #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2017
Merged

allow options outside <select> elements #1048

merged 2 commits into from
Dec 24, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #1022 and hopefully #1035

@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #1048 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   92.01%   92.01%   +<.01%     
==========================================
  Files         121      121              
  Lines        4368     4369       +1     
  Branches     1408     1409       +1     
==========================================
+ Hits         4019     4020       +1     
  Misses        148      148              
  Partials      201      201
Impacted Files Coverage Δ
src/generators/nodes/Element.ts 95% <100%> (ø) ⬆️
src/generators/nodes/Component.ts 94.95% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8472142...6d9abe2. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 831cc41 into master Dec 24, 2017
@Rich-Harris Rich-Harris deleted the gh-1022 branch December 24, 2017 17:15
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
* bump prettier-plugin-svelte

* format

* another
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<option> outside of <select> throws error
2 participants