deconflict referenced globals #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 123 123
Lines 4477 4483 +6
Branches 1443 1445 +2
==========================================
+ Hits 4098 4104 +6
Misses 162 162
Partials 217 217
Continue to review full report at Codecov.
|
Conduitry
requested changes
Jan 11, 2018
package.json
Outdated
| @@ -87,5 +87,8 @@ | |||
| ], | |||
| "sourceMap": true, | |||
| "instrument": true | |||
| }, | |||
| "dependencies": { | |||
| "is-reference": "^1.1.0" | |||
There was a problem hiding this comment.
Probably want this a dev dependency
|
Nice! |
Conduitry
approved these changes
Jan 11, 2018
7nik
pushed a commit
to 7nik/svelte
that referenced
this pull request
Apr 9, 2025
sync svelte docs Co-authored-by: Rich-Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1079. This is an alternative to #1090 — it does basically the same thing, but without the additional AST walk