Skip to content

Add destructured context container to usedContexts #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2018

Conversation

jacobmischka
Copy link
Contributor

Fixes #1139

I also rewrote a little chunk that had a variable that wasn't being used anywhere anymore.

@jacobmischka
Copy link
Contributor Author

jacobmischka commented Feb 2, 2018

It's possible that this line could be removed in this circumstance, but I'm not sure enough to do so and it doesn't seem to hurt anything being there, ha.

31de60e#diff-faf6bf53ae607c055bf386d2fe896c01L256

Edit: Not removed I mean, just that we probably don't need to add the non-destructured name to contexts as well. Of course the name should still be added in other cases.

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #1145 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
- Coverage   91.48%   91.44%   -0.05%     
==========================================
  Files         126      126              
  Lines        4521     4522       +1     
  Branches     1458     1459       +1     
==========================================
- Hits         4136     4135       -1     
  Misses        163      163              
- Partials      222      224       +2
Impacted Files Coverage Δ
src/generators/Generator.ts 93.63% <100%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e9343...2635de8. Read the comment docs.

@Rich-Harris Rich-Harris merged commit ca779a4 into sveltejs:master Feb 3, 2018
@Rich-Harris
Copy link
Member

niiiice 👍

7nik pushed a commit to 7nik/svelte that referenced this pull request Apr 9, 2025
sync svelte docs

Co-authored-by: svelte-docs-bot[bot] <196124396+svelte-docs-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants