fix: allow slot attribute inside snippets #12188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone could render a snippet into a custom element, and therefore elements with slot attributes should be allowed within them and be treated as regular elements closes #12158
🦋 Changeset detectedLatest commit: 85fec65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
approved these changes
Jun 26, 2024
FoHoOV
pushed a commit
to FoHoOV/svelte
that referenced
this pull request
Jun 27, 2024
Someone could render a snippet into a custom element, and therefore elements with slot attributes should be allowed within them and be treated as regular elements closes sveltejs#12158
trueadm
pushed a commit
that referenced
this pull request
Jun 27, 2024
Someone could render a snippet into a custom element, and therefore elements with slot attributes should be allowed within them and be treated as regular elements closes #12158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone could render a snippet into a custom element, and therefore elements with slot attributes should be allowed within them and be treated as regular elements
closes #12158
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint