Skip to content

fix: make more types from svelte/compiler public #12189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

dummdidumm
Copy link
Member

The types generation script used the wrong entry point, as a consequence not all types that should've been exposed where actually made public

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Sorry, something went wrong.

The types generation script used the wrong entry point, as a consequence not all types that should've been exposed where actually made public
Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: 7295cab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 09479c4 into main Jun 26, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the compiler-types branch June 26, 2024 13:56
FoHoOV pushed a commit to FoHoOV/svelte that referenced this pull request Jun 27, 2024
The types generation script used the wrong entry point, as a consequence not all types that should've been exposed where actually made public
trueadm pushed a commit that referenced this pull request Jun 27, 2024
The types generation script used the wrong entry point, as a consequence not all types that should've been exposed where actually made public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants