Skip to content

fix(types): export CompileResult and Warning #12212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

dominikg
Copy link
Member

used by vite-plugin-svelte and exported in svelte4 too

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 933b81d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member Author

/ecosystem-ci run vite-plugin-svelte

@svelte-ecoystem-ci
Copy link

svelte-ecoystem-ci bot commented Jun 27, 2024

📝 Ran ecosystem CI: Open

suite result
vite-plugin-svelte ❌ failure

@dominikg
Copy link
Member Author

the failure in ecosystem-ci is now different. the fail this solves was a type error, now it fails with mismatching snapshots (kind of expected, i'll skip the snapshot tests until output is more stable)

@dominikg dominikg merged commit 266f669 into main Jun 27, 2024
9 checks passed
@dummdidumm dummdidumm deleted the fix/export-compiler-types branch June 27, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants