feat: make <svelte:option> customElement configuration's tag property optional (#12751) #12754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
As described in #12751, there are cases when users might want to use the advanced custom element configuration by
<svelte:option customElement={...}>
and still have control over when and how the custom element is defined with the customElements registry.recap:
fix: making
tag
optional in the configuration object as wellthis PR makes it so that the tag property of the
customElement
configuration object now too is optional.If a tag name is set, the element is registered automatically. If not, registering the element is left to the user.
This basically mirrors the behavior of how the non-object variant of
customElement
worksBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint