chore: improve SSR parent element validation #13158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 956f027 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Going to merge this as it seems uncontroversial and likely just an oversight. |
Rich-Harris
added a commit
that referenced
this pull request
Sep 15, 2024
This reverts commit 0332abb.
Rich-Harris
added a commit
that referenced
this pull request
Sep 15, 2024
5 tasks
Rich-Harris
added a commit
that referenced
this pull request
Sep 16, 2024
dummdidumm
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts #13255 / #13158, and helps with the validation error part of #14120 The revert is justified because people should be free to render a component in isolation and then append it somewhere where they know the rendered output is valid. If someone renders a tag at the top level that is invalid without a certain parent (which itself is an edge case), then the likelihood that this is done on purpose is much higher than that it's done by accident.
dummdidumm
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts #13255 / #13158, and helps with the validation error part of #14120 If you would have a component like this... ```svelte <td>hi there</td> ``` ...and then render it on the server via our `render` function like this: ```js const result = render(Main); ``` ...then right now you get an error saying that `td` is not valid at this position. But that doesn't seem right, because we should give people the benefit of the doubt: It may very well be that someone renders such a component and then correctly puts it into a `tr` tag themselves on the server (another example is rendering a full html document like in #14120). All the other validation where there's a known parent (X not valid inside Y) is untouched by this. Doing this as cleanup prior to tackling #13331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic is wonky, if we don't have a
parent_tagwe should still continue to validate the element.