-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
integrate CLI #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate CLI #1389
Conversation
This is failing because the CLI uses a) rewrite using regular promises Transpiling wouldn't be that onerous I suppose, would just need to port it to TypeScript. Probably the lowest friction approach |
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
==========================================
+ Coverage 91.19% 91.24% +0.04%
==========================================
Files 122 122
Lines 4465 4465
Branches 1377 1377
==========================================
+ Hits 4072 4074 +2
+ Misses 156 154 -2
Partials 237 237
Continue to review full report at Codecov.
|
What does TypeScript compile async/await to? Having semi-legible transpiled code is nice, which in this case would mean hopefully generators (supported in Node 6) as opposed to impenetrable switch statements. |
It compiles surprisingly well, though it's still not what you'd call human-readable. Though I just looked again, and we're actually barely using async/await at all in the CLI, so I just rewrote it with normal promises for now. |
@@ -0,0 +1,173 @@ | |||
/* src/Main.html generated by Svelte v2.3.0 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to do whatever string replacement we do in other tests here, so that this comment won't have to change each version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea — have done that
I think you need to add a |
D'oh, of course. I'm not sure you can just point it at the dist file though — I've had issues with permissions in the past where I needed to |
fixes #1360