Skip to content

evaluate each block key in child scope #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2018
Merged

evaluate each block key in child scope #1402

merged 2 commits into from
May 3, 2018

Conversation

Rich-Harris
Copy link
Member

fixes #1397

@Conduitry
Copy link
Member

At first I was wondering why this was passing in Travis and not Appveyor - but it looks like for some reason the tests are not actually being run in Appveyor? I'm not sure what to make of that build log

@Rich-Harris
Copy link
Member Author

Yeah, I just spotted the exact same thing. Raised an issue for it. Weird

@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #1402 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1402   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         122      122           
  Lines        4485     4485           
  Branches     1385     1385           
=======================================
  Hits         4093     4093           
  Misses        154      154           
  Partials      238      238
Impacted Files Coverage Δ
src/compile/nodes/EachBlock.ts 98.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec21f7...3f012bb. Read the comment docs.

@Rich-Harris Rich-Harris merged commit eff4319 into master May 3, 2018
@Rich-Harris Rich-Harris deleted the gh-1397 branch May 3, 2018 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each block key incorrectly treated as expected data property
3 participants