unique name for select_block_type in IfBlock#buildCompoundWithOutros #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Conduitry are you sure that the bug is fixed? As I understood this problem wiil still appearing in REPL because of sveltejs/v2.svelte.dev#327. But everything should work properly in a some new project? |
|
The issue with the REPL makes it so that the compiled code that's displayed isn't what's actually run. That hasn't been fixed yet. I am pretty sure this PR fixes your issue, but a new version of Svelte with it hasn't been released yet. |
|
I believe Rich is still on vacation, so my current plan is to check this evening whether there is another issue I can knock out relatively easily, and then either way cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1580
select_block_typeinIfBlock#buildCompoundWithOutroswas getting a unique name within its block, which is not what we want, as it can conflict with that in other blocks. We want it to be globally unique, like the one inIfBlock#build.