Skip to content

fix: enhance class selector matching to include ClassDirective attributes #16202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-insects-flow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: restore ClassDirective check for compound class selectors in CSS pruning
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,12 @@ function relative_selector_might_apply_to_node(relative_selector, rule, element,
}

case 'ClassSelector': {
if (!attribute_matches(element, 'class', name, '~=', false)) {
if (
!attribute_matches(element, 'class', name, '~=', false) &&
!element.attributes.some(
(attribute) => attribute.type === 'ClassDirective' && attribute.name === name
)
) {
return false;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { test } from '../../test';

export default test({
warnings: [
{
code: 'css_unused_selector',
message: 'Unused CSS selector ".unused"\nhttps://svelte.dev/e/css_unused_selector',
start: {
line: 18,
column: 1,
character: 231
},
end: {
line: 18,
column: 8,
character: 238
}
}
]
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
.sidebar.collapsed.svelte-xyz {
width: 60px;
}

.collapsed.svelte-xyz .content:where(.svelte-xyz) {
opacity: 0;
}

/* (unused) .unused {
color: red;
}*/
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<script>
let collapsed = false;
</script>

<div class="sidebar" class:collapsed={collapsed}>
<div class="content">Content</div>
</div>

<style>
.sidebar.collapsed {
width: 60px;
}

.collapsed .content {
opacity: 0;
}

.unused {
color: red;
}
</style>