fix: avoid recursion error when tagging circular references

[Ocean-OS]

Closes #16620

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with feat:, fix:, chore:, or docs:.
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.
• If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

• Run the tests with pnpm test and lint the project with pnpm lint

[changeset-bot]

🦋 Changeset detected

Latest commit: e738d6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Playground

pnpm add https://pkg.pr.new/svelte@16622

[7nik]

Won't it be cheaper to set a flag that update_path runs to it shouldn't run again due to circular deps?

[Ocean-OS]

what do you mean?

[7nik]

let updating = false;
function update_path(new_path) {
  if (updating) return; // met a circular dependency
  updating = true;
  // fn body
  updating = false;
}

[Ocean-OS]

thanks!

[7nik]

But, unlike the previous solution, it causes weird tags 🤔

[paoloricciuti]

But, unlike the previous solution, it causes weird tags 🤔

When i was exploring this i think it's because when we set we create an unlabeled proxy (so I think it's semi, unrelated to this)

[Ocean-OS]

when you say set, do you mean the set proxy handler or the set function?

[7nik]

Nice. I guess we still need a test, right?

[paoloricciuti]

when you say set, do you mean the set proxy handler or the set function?

Ugh sorry, I missed this but I think you found it right?