Skip to content

Examples #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 11, 2019
Merged

Examples #2199

merged 17 commits into from
Mar 11, 2019

Conversation

Rich-Harris
Copy link
Member

Starting work on the examples page. First order of business — removing all the data.json5 files, and moving the data into the components themselves. This will allow us to get rid of the props editor, which a) takes up valuable real estate, b) is rarely used, c) is a source of confusion, and d) is a bug magnet.

I'm planning to remove the examples dropdown from the REPL page, and have all these things showcased properly on a dedicated page, with thumbnails that take you to a prepopulated REPL.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding
@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #2199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2199   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4be42...71da0be. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding
@Rich-Harris
Copy link
Member Author

Made some progress: https://v3sveltetechnology-ijjerzyadp.now.sh/examples

At the moment I've just moved all the tutorial examples over. Some of them should be removed, and some of the previous examples should be moved back in.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding
@Rich-Harris Rich-Harris marked this pull request as ready for review March 11, 2019 02:32
@Rich-Harris
Copy link
Member Author

Not 100% happy with the design but it'll do for now. Better than nothing

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tcharding Tobin C. Harding
@Rich-Harris Rich-Harris merged commit 863eff9 into master Mar 11, 2019
@Rich-Harris Rich-Harris deleted the examples branch March 11, 2019 02:35
@paulovieira
Copy link

The organization is much better now. It's easy to get a general understanding of svelte3.

A possible improvement would have a quick "tutorial" for each example, separate from the REPL. The tutorial could give some more context and explanations.

Here are 2 references that are well done, i think, and that could be used for inspiration:

I'm happy to help!

@Rich-Harris
Copy link
Member Author

There's a tutorial here https://v3.svelte.technology/tutorial/basics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants