Skip to content

Disallow export ... from statements #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Disallow export ... from statements #2225

merged 2 commits into from
Mar 15, 2019

Conversation

Conduitry
Copy link
Member

Works around #2214 for the time being. Also upgrades Acorn so that export { some_undeclared_global }; is a parsing error.

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #2225 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2225   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863eff9...b328cec. Read the comment docs.

@Conduitry Conduitry added this to the 3.0 milestone Mar 15, 2019
@Rich-Harris Rich-Harris merged commit e2a71cf into master Mar 15, 2019
@Rich-Harris Rich-Harris deleted the gh-2214 branch March 15, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants