Skip to content

ensures sequential lifecycle ending in afterUpdate #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ensures sequential lifecycle ending in afterUpdate #3307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/runtime/internal/scheduler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ export function flush() {
const seen_callbacks = new Set();

do {
// invalidate bindings before checking dirty_components
while (binding_callbacks.length) binding_callbacks.pop()();

// first, call beforeUpdate functions
// and update components
while (dirty_components.length) {
Expand All @@ -43,8 +46,6 @@ export function flush() {
update(component.$$);
}

while (binding_callbacks.length) binding_callbacks.pop()();

// then, once components are updated, call
// afterUpdate functions. This may cause
// subsequent updates...
Expand Down