Support RxJS Observables in reassigned stores #3315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3304.
This also refactors stuff a little bit. The
subscribe
helper is now calledcomponent_subscribe
(for lack of a better name), and there's a newsubscribe
helper that just does subscription and returns the unsubscription function, whether this is a Svelte store or an RxJS observable. This new helper is now used incomponent_subscribe
,get_store_value
, and in the store reassignment/resubscription handling code.