Skip to content

deconflict with builtins #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

tanhauhau
Copy link
Member

Fixes #3724

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Rich-Harris
Copy link
Member

Thank you. I'm confused about why each_anchor is now being turned into each_1_anchor — any ideas? Is it avoidable?

@tanhauhau
Copy link
Member Author

because each is a builtin method name, that's why it's suffixed to each_1, which concatenate with _anchor.

I'm not sure how to register var as each_anchor instead, would lead to more code change

@Conduitry Conduitry merged commit fca35de into sveltejs:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Text is not a function" (svelte@next)
3 participants