Fix boolean attributes in presence of spread attributes #3775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3764, with the assumption that #3750 may mean that it would become even more impractical to ship attribute-to-property tables along with the runtime.
In short:
attribute_lookup
metadata) given for a node that has at least one spread, the compiler will emit the appropriate property key in the object in the spread arrays. For example,{ readOnly: whatever }
instead of{ readonly: whatever }
.{ readonly: whatever || null }
instead of{readonly: whatever }
for boolean attributes, to ensure that thespread()
function does not serialize falsy attributes.Bonus SSR bugs I bumped into and fixed while addressing this:
{...{ foo: null }}
was getting serialized asfoo="null"
becausespread()
was checking for strict equality withundefined
. It's now checking for loose equality withnull
.value
,class
, or any boolean attribute to take effect. These checks are now done case-insensitively.