Skip to content

feat allow multiple elements assigned with same slot #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat allow multiple elements assigned with same slot #4140

wants to merge 1 commit into from

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Dec 21, 2019 •
edited
Loading

fix: #4135

allows multiple elements to assigned into the same slot, see the use case in repl: https://svelte.dev/repl/193a784e481947979ee20f97a8fc8200?version=3.16.5

@tanhauhau tanhauhau force-pushed the tanhauhau/multiple-slot-let-binding branch from b340271 to 5b030d0 Compare December 23, 2019 03:02
@Conduitry
Copy link
Member

IIRC the general consensus in chat when this was being discussed was that multiple elements with the same slot="" should be disallowed at compile time, and that we should pursue a different syntax for slots without a single top-level DOM element. Closing.

@Conduitry Conduitry closed this Feb 9, 2020
@tanhauhau tanhauhau deleted the tanhauhau/multiple-slot-let-binding branch March 5, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

let-binding fails when multiple elements are assigned to the same slot
2 participants
@tanhauhau @Conduitry