Skip to content

simplifies code contributions by fully automating the dev setup #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nisarhassan12
Copy link

@nisarhassan12 nisarhassan12 commented Jan 17, 2020

Hi! 🙂

This Pr simplifies code contributions by fully automating the setup with Gitpod (A free online VS Code-like IDE) with a single click it will launch a workspace and automatically:

  • clone the svelte repo.
  • install the dependencies.
  • run npm run dev in / and /site.

So that anyone interested in contributing can start straight away.

It seems to work well :) You can give it a try on my fork via the link below:

https://gitpod.io/#https://github.com/nisarhassan12/svelte/tree/gitpod-setup

image

@nisarhassan12 nisarhassan12 changed the title simplifies code contributions by fully automating the setup with Gitpod simplifies code contributions by fully automating the setup Jan 17, 2020
@nisarhassan12 nisarhassan12 changed the title simplifies code contributions by fully automating the setup simplifies code contributions by fully automating dev the setup Jan 17, 2020
@nisarhassan12 nisarhassan12 changed the title simplifies code contributions by fully automating dev the setup simplifies code contributions by fully automating the dev setup Jan 17, 2020
@ghost
Copy link

ghost commented Jan 21, 2020

Interesting concept, but contributing is more than just editing code files.
Can this also run the test suite and/or debug Node (maybe yes because it is a Docker container)?

Edit:

The major problem with including this in the core is that some devs out there may already have these workflows in place or develop within Docker containers. Also, once code gets committed to the project, it becomes the maintainers responsibility to keep it in a functional state. Having to check if we've broken this coding environment will likely become very cumbersome with the velocity of releases that Svelte has lately.

@nisarhassan12
Copy link
Author

Thanks! It can run the test suites in both / & /site
image

@nisarhassan12
Copy link
Author

nisarhassan12 commented Jan 21, 2020

Interesting concept, but contributing is more than just editing code files.
Can this also run the test suite and/or debug Node (maybe yes because it is a Docker container)?

Edit:

The major problem with including this in the core is that some devs out there may already have these workflows in place or develop within Docker containers. Also, once code gets committed to the project, it becomes the maintainers responsibility to keep it in a functional state. Having to check if we've broken this coding environment will likely become very cumbersome with the velocity of releases that Svelte has lately.

Thanks @dkondrad I volunteer for maintaining the config i.e I will check regularly and anyone can freely mention me on any issues.

Gitpod is already in use by many popular Open-source projects some of them are:

@nisarhassan12 nisarhassan12 requested review from Rich-Harris and removed request for Rich-Harris January 22, 2020 04:28
@nisarhassan12 nisarhassan12 force-pushed the gitpod-setup branch 2 times, most recently from 158b254 to 400c6f2 Compare March 20, 2020 11:05
@nisarhassan12
Copy link
Author

Rebased on top of latest master @Conduitry @tanhauhau

@Conduitry
Copy link
Member

Gitpod is certainly an impressive technical accomplishment, but I don't think this is something we want to officially integrate with and endorse and mention in the readme. The Svelte dev environment is pretty painless to set up as it is for anyone who's used Git and npm before. And given the low relative value that Gitpod would seem to provide, it doesn't sit right with me to direct people (even optionally) to use a particular third-party freemium service. (You say 'free' in your PR, but it does have per-month time limits that make it impossible to use for anything but a hobby.)

You can say that you'd be timely in keeping this up to date, but the responsibility would still ultimately fall on Svelte's maintainers to field questions about this new moving part and to make sure it keeps working (and we'd have little familiarity with this, as we'd continue to do all our work in locally checked out repos), and if the burden got to be too much, I don't want to have to worry about irritating people by the integration being removed.

So, thank you for the thought and for the cool piece of tech, but closing.

Copy link

@Andrea-MariaDB-2 Andrea-MariaDB-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@alfred110 alfred110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitpod.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants