fix indirect bindings on elements with spreads #4398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseskinner
pushed a commit
to jesseskinner/svelte
that referenced
this pull request
Feb 27, 2020
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3680. On indirectly bound values, what's important is the custom
__valueproperty on the element. This makes the combined object of props/attrs used in spreads include__valueinstead ofvaluein cases where there is an indirect binding - and also updates theset_attributeshelper to include a special case for__value, which we would otherwise try to set as an attribute since it's not a valid property on the prototype.This does not address #4397, which I split off as a separate issue, and looks to be unrelated to the spread.
It also does not address #4392, which is less of a related issue than I had hoped it would be.