Skip to content

Check const variable binding #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2020
Merged

Check const variable binding #4506

merged 3 commits into from
Mar 14, 2020

Conversation

vlasy
Copy link
Contributor

@vlasy vlasy commented Mar 4, 2020

Resolves #4479

Hope that this implementation is the right one.

@Conduitry Conduitry merged commit e06a900 into sveltejs:master Mar 14, 2020
@vlasy vlasy deleted the check-const-bind branch March 19, 2020 08:11
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@vlasy @taylorzane
throw compiler error when binding directly to const variables (svelte…
07f2ee3 
…js#4506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau tanhauhau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw a warning if we are declaring a variable with const and also using bind directive to mutate its value.
3 participants
@vlasy @tanhauhau @Conduitry