Fix: input type number warning in browsers #4772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this issue is still actual. |
Th0rN13
force-pushed
the
fix/bind-input-number-null
branch
from
36de7dc to
f88381c
Compare
tanhauhau
approved these changes
Jun 11, 2020
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1701
Redo tests, but this case it cant be direct tested, only warning in browsers.
You can check this warnings in browser via REPL
If you set string or undefined to input-type-number binded variable browser show warning in devtools console. You need set number and then other "wrong" value to repeat warning
To check usecase, check REPL from 1701 issue, but look not to repl console, but browser console.