-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Allow using the compiler as an ESM module #4972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good! Waiting for core team approval 👍 |
Bump, I notice there are some lint errors, but if that's an issue can we let @Pierstoval know or merge this as is? (could do a fixup PR later if an issue) |
I just rebased on |
I was incorrect about the lint issues.
|
You can ignore the lint issues, they're because we added loose linting rules and tried not to break the existing collection of PRs. It's on my list to fix all of the lint issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, it publishes a completely separate mjs
version of the compiler.
Thanks for merging 👍 |
This PR provides a first solution to #4806, allowing the compiler to be built to ESM