-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Await: re-throw error when there is no catch block and promise is rejected #5149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conduitry
merged 4 commits into
sveltejs:master
from
irshadshalu:await_throw_error_when_no_catch_block
Aug 17, 2020
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e297182
await: rethrow error when there is no catch block, fixes #5129
irshadshalu cd3d0f6
Passing hasCatch since it is not possible to infer whether catch bloc…
irshadshalu 776a7e2
Removing console.log
irshadshalu b9915b2
Determining value of hasCatch on build time
irshadshalu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
let fulfil; | ||
|
||
let promise = new Promise(f => { | ||
fulfil = f; | ||
}); | ||
|
||
export default { | ||
props: { | ||
promise | ||
}, | ||
|
||
html: ` | ||
<p>loading...</p> | ||
`, | ||
|
||
test({ assert, component, target }) { | ||
fulfil(42); | ||
|
||
return promise | ||
.then(() => { | ||
assert.htmlEqual(target.innerHTML, ` | ||
<p>loaded</p> | ||
`); | ||
|
||
let reject; | ||
|
||
promise = new Promise((f, r) => { | ||
reject = r; | ||
}); | ||
|
||
component.promise = promise; | ||
|
||
assert.htmlEqual(target.innerHTML, ` | ||
<p>loading...</p> | ||
`); | ||
|
||
reject(new Error('this error should be thrown')); | ||
return promise; | ||
}) | ||
.catch((err) => { | ||
assert.equal(err.message, 'this error should be thrown'); | ||
}); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<script> | ||
export let promise; | ||
</script> | ||
|
||
{#await promise} | ||
<p>loading...</p> | ||
{:then value} | ||
<p>loaded</p> | ||
{/await} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.