fix each block destructuring can't have default values refer to destructured params #5230
Conversation
habibrosyad
changed the title
| const n = contexts.length; | ||
|
|
||
| unpack_destructuring(contexts, value.left, node => { | ||
| const alternate = JSON.parse(JSON.stringify(value.right)); |
There was a problem hiding this comment.
because the node will be altered in update_reference and I cannot get it right without cloning it. I noticed that modifier will be called several times in the process, if the node changes during the process (as value.right is basically a closure to modifier), then the conditions for finding reference in update_reference will be failed as the node has been replaced for the next call.
| update_reference(contexts, node, current_node, 'callee'); | ||
| } else if (current_node.type === 'MemberExpression') { | ||
| update_reference(contexts, node, current_node, 'object'); | ||
| update_reference(contexts, node, current_node, 'property'); |
There was a problem hiding this comment.
I dont think you would want to update reference for MemberExpression#property,
you might be updating the reference of foo in a.foo below.
{#each arrays as { foo, bar = a.foo } }There was a problem hiding this comment.
Oh yeah, you're right, missed that one...
|
|
||
| if (!current_node || !contexts.length) return; | ||
|
|
||
| if (current_node.type === 'Identifier') { |
There was a problem hiding this comment.
probably can use estree-walker to traverse down the node.
There was a problem hiding this comment.
you can use is-reference to determine whether the Identifier is a reference or not.
There was a problem hiding this comment.
will try to use estree-walker, I've seen it to be used in some codes there but hesitated since doing recursive looks more compelling...
habibrosyad
force-pushed
the
patch-5066
branch
from
66debf4 to
56a03bd
Compare
habibrosyad
force-pushed
the
patch-5066
branch
from
56a03bd to
0beee4e
Compare
|
Thanks for the PR, and sorry it took so long to get in! I'm closing this as these changes were incorporated into #5986, which has now been merged and released in 3.33.0. |
Fix #5066
Before submitting the PR, please make sure you do the following
npm run lint!)This REPL as mentioned in {#each} block destructuring can't have default values refer to destructured params #5066 failed without this PR.
Tests
npm testoryarn test)