Skip to content

Set Element's Value attribute to empty string "" if it is undefined #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

asvsfs
Copy link

@asvsfs asvsfs commented Aug 5, 2020

Before submitting the PR, please make sure you do the following

  • [] It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

This is a simple one addressing issue #5197 #4467
now elements with value attribute will have a default value ('') in case of undefined , it is more expected behavior and less bug prone.

@asvsfs asvsfs changed the title Input val Set Element's Value attribute to empty string "" if it is undefined Aug 5, 2020
@asvsfs asvsfs closed this Aug 5, 2020
@asvsfs asvsfs deleted the input_val branch August 5, 2020 07:24
@asvsfs asvsfs restored the input_val branch August 5, 2020 07:24
@asvsfs asvsfs reopened this Aug 5, 2020
@asvsfs asvsfs closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant