Skip to content

fix reference for namespaced component #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

* In SSR mode, do not automatically declare variables for reactive assignments to member expressions ([#5247](https://github.com/sveltejs/svelte/issues/5247))
* Fix using `<Namespaced.Component/>`s in child `{#await}`/`{#each}` contexts ([#5255](https://github.com/sveltejs/svelte/issues/5255))

## 3.24.1

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { Node, Identifier, ObjectExpression } from 'estree';
import EventHandler from '../Element/EventHandler';
import { extract_names } from 'periscopic';
import mark_each_block_bindings from '../shared/mark_each_block_bindings';
import { string_to_member_expression } from '../../../utils/string_to_member_expression';

export default class InlineComponentWrapper extends Wrapper {
var: Identifier;
Expand Down Expand Up @@ -484,7 +485,7 @@ export default class InlineComponentWrapper extends Wrapper {
} else {
const expression = this.node.name === 'svelte:self'
? component.name
: this.renderer.reference(this.node.name);
: this.renderer.reference(string_to_member_expression(this.node.name));

block.chunks.init.push(b`
${(this.node.attributes.length > 0 || this.node.bindings.length > 0) && b`
Expand Down
17 changes: 17 additions & 0 deletions src/compiler/compile/utils/string_to_member_expression.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { MemberExpression, Identifier } from "estree";

export function string_to_member_expression(name: string) {
const parts = name.split(".");
let node: MemberExpression | Identifier = {
type: "Identifier",
name: parts[0],
};
for (let i = 1; i < parts.length; i++) {
node = {
type: "MemberExpression",
object: node,
property: { type: "Identifier", name: parts[i] },
} as MemberExpression;
}
return node;
}
1 change: 1 addition & 0 deletions test/runtime/samples/component-namespace/Tooltip.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p>i am a widget</p>
5 changes: 5 additions & 0 deletions test/runtime/samples/component-namespace/Widget.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script context="module">
import Tooltip from './Tooltip.svelte';

export const Widget = { Tooltip };
</script>
3 changes: 3 additions & 0 deletions test/runtime/samples/component-namespace/_config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default {
html: '<p>i am a widget</p>'
};
8 changes: 8 additions & 0 deletions test/runtime/samples/component-namespace/main.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<script>
import { Widget } from './Widget.svelte';
let widgets = [Widget];
</script>

{#each widgets as LazyWidget}
<LazyWidget.Tooltip />
{/each}