Skip to content

fix: Set return type of get_store_value to store value type #5474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Set return type of get_store_value to store value type #5474

wants to merge 1 commit into from

Conversation

tje3d
Copy link

@tje3d tje3d commented Sep 30, 2020

Im not really sure if i missed something, but at least it fixes my issue

before:
2020-09-30-125529_726x197_scrot

after:
2020-09-30-125550_536x191_scrot

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

Sorry, I noticed this after I saw and merged the duplicate #5483 - closing. Thank you though!

@Conduitry Conduitry closed this Oct 1, 2020
@tje3d tje3d deleted the get-store-value branch October 1, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tje3d @Conduitry