Skip to content

tutorial: remove unnecessary call performance.now() inside raf #5513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

tutorial: remove unnecessary call performance.now() inside raf #5513

merged 1 commit into from
Nov 18, 2020

Conversation

fivemru
Copy link
Contributor

@fivemru fivemru commented Oct 10, 2020

The callback called via requestAnimationFrame(callback) already contains the timestamp in the first argument, calling performance.now() inside raf is not required.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@benmccann benmccann mentioned this pull request Oct 22, 2020
Merged
4 tasks
@Conduitry Conduitry merged commit ddd79e3 into sveltejs:master Nov 18, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@fivemru @taylorzane
tutorial: remove unneccessary performance.now() call inside raf (svel…
7db04d2 
…tejs#5513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau tanhauhau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fivemru @tanhauhau @benmccann @Conduitry